Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: open_url not working on windows #3130

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

scarf005
Copy link
Member

Summary

SUMMARY: Bugfixes "Made 'Submit a bug report on Github debug' work correctly on windows"

Purpose of change

Describe the solution

https://chat.openai.com/share/af7046b4-832d-467f-a1d9-700546554c31

Testing

manually typing the command on CMD.exe worked

#3128 (comment)

@github-actions github-actions bot added the src changes related to source code. label Sep 11, 2023
@olanti-p
Copy link
Contributor

https://chat.openai.com/share/af7046b4-832d-467f-a1d9-700546554c31

That link is dead or private.

Also, LLMs are not always correct when it comes to code, their results should be double-checked.

src/url_utility.cpp Outdated Show resolved Hide resolved
@scarf005
Copy link
Member Author

scarf005 commented Sep 11, 2023

image
strange, i can access it from private mode.

https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/start suggests start can be used on both 32bit and 64bit machine, so i think it'd be okay.

@scarf005 scarf005 merged commit 8fc63e4 into cataclysmbnteam:upload Sep 11, 2023
@scarf005 scarf005 deleted the fix-bug-report-on-windows branch September 11, 2023 22:49
@scarf005
Copy link
Member Author

doesn't seem to work, #3321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submit a bug report on Github debug button fails to generate report
2 participants